From cf0bb56c57800baf162f37e5a606a8ba6734fa53 Mon Sep 17 00:00:00 2001
From: xljiulang <366193849@qq.com>
Date: Tue, 20 Jul 2021 23:45:52 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E6=94=B9=E6=B3=A8=E9=87=8A?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 FastGithub.ReverseProxy/DomainResolver.cs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/FastGithub.ReverseProxy/DomainResolver.cs b/FastGithub.ReverseProxy/DomainResolver.cs
index 31be4a1..3b89980 100644
--- a/FastGithub.ReverseProxy/DomainResolver.cs
+++ b/FastGithub.ReverseProxy/DomainResolver.cs
@@ -25,7 +25,8 @@ namespace FastGithub.ReverseProxy
         /// 域名解析器
         /// </summary>
         /// <param name="memoryCache"></param>
-        /// <param name="fastGithubConfig"></param>
+        /// <param name="options"></param>
+        /// <param name="logger"></param>
         public DomainResolver(
             IMemoryCache memoryCache,
             IOptionsMonitor<FastGithubOptions> options,
@@ -45,16 +46,15 @@ namespace FastGithub.ReverseProxy
         /// <param name="domain"></param>
         /// <returns></returns>
         /// <exception cref="FastGithubException"></exception>
-        public async Task<IPAddress> ResolveAsync(string domain, CancellationToken cancellationToken)
+        public Task<IPAddress> ResolveAsync(string domain, CancellationToken cancellationToken)
         {
             // 缓存以避免做不必要的并发查询
-            var key = $"domain:{domain}";
-            var address = await this.memoryCache.GetOrCreateAsync(key, e =>
+            var key = $"{nameof(DomainResolver)}:{domain}";
+            return this.memoryCache.GetOrCreateAsync(key, e =>
             {
                 e.SetAbsoluteExpiration(this.cacheTimeSpan);
                 return this.LookupAsync(domain, cancellationToken);
             });
-            return address;
         }
 
         /// <summary>
@@ -76,7 +76,7 @@ namespace FastGithub.ReverseProxy
                 }
 
                 // 受干扰的dns，常常返回127.0.0.1来阻断请求
-                // 如果解析到的ip为本机ip，会产生反向代理请求死循环
+                // 虽然DnscryptProxy的抗干扰能力，但它仍然可能降级到不安全的普通dns上游
                 if (address.Equals(IPAddress.Loopback))
                 {
                     throw new Exception($"dns被污染，解析{domain}为{address}");